[
https://issues.apache.org/jira/browse/FLINK-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667134#comment-16667134
]
ASF GitHub Bot commented on FLINK-10687:
----------------------------------------
twalthr commented on a change in pull request #6958: [FLINK-10687] [table] Make
flink-formats Scala-free
URL: https://github.com/apache/flink/pull/6958#discussion_r228906783
##########
File path:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/typeutils/TypeStringUtilsTest.scala
##########
@@ -103,13 +104,18 @@ class TypeStringUtilsTest {
// test escaping
assertTrue(
- TypeStringUtils.readTypeInfo("ROW<\"he \\nllo\" DECIMAL, world
TINYINT>")
+ TypeStringUtils.readTypeInfo("ROW<`he \nllo` DECIMAL, world
TINYINT>")
Review comment:
The handling of escaping was simply wrong in this class. Similar efforts
have been done recently for https://issues.apache.org/jira/browse/FLINK-10281.
Backticks (or double backticks) are used in SQL and also other vendors such as
Hive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Make flink-formats Scala-free
> -----------------------------
>
> Key: FLINK-10687
> URL: https://issues.apache.org/jira/browse/FLINK-10687
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Timo Walther
> Priority: Major
> Labels: pull-request-available
>
> {{flink-table}} is the only dependency that pulls in Scala for
> {{flink-json}}, {{flink-avro}}. We should aim to make {{flink-formats}}
> Scala-free using only a dependency to {{flink-table-common}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
