[
https://issues.apache.org/jira/browse/FLINK-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674455#comment-16674455
]
ASF GitHub Bot commented on FLINK-10772:
----------------------------------------
tillrohrmann opened a new pull request #7016: [FLINK-10772][release] Fix
create_binary_release.sh
URL: https://github.com/apache/flink/pull/7016
## What is the purpose of the change
Remove the unnecessary call to change_scala_version.sh and remove the
-Dmaven.test.skip=true property. The latter is necessary because this
property suppresses the compilation and packaging of test classes. It,
however, does not suppress the resolution of test dependencies which
will then fail to compile because test dependencies have not been built.
This commit also removes the redundant call to build
flink-shaded/hadoop/flink-shaded-hadoop2-uber which is a dependency
of flink-dist anyway.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> create_binary_release.sh is broken
> ----------------------------------
>
> Key: FLINK-10772
> URL: https://issues.apache.org/jira/browse/FLINK-10772
> Project: Flink
> Issue Type: Bug
> Components: Build System
> Affects Versions: 1.7.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> The {{create_binary_release.sh}} is broken because it calls a script which
> does not exist. In fact, this script no longer needs to be called.
> Moreover, the build fails because we skip the compilation and packaging of
> test dependencies via {{-Dmaven.test.skip=true}}. The problem is that test
> dependencies are still being resolved if this property is specified.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
