[
https://issues.apache.org/jira/browse/FLINK-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674997#comment-16674997
]
ASF GitHub Bot commented on FLINK-10772:
----------------------------------------
tillrohrmann closed pull request #7016: [FLINK-10772][release] Fix
create_binary_release.sh
URL: https://github.com/apache/flink/pull/7016
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tools/releasing/create_binary_release.sh
b/tools/releasing/create_binary_release.sh
index 814612791cb..f4d7c5770ca 100755
--- a/tools/releasing/create_binary_release.sh
+++ b/tools/releasing/create_binary_release.sh
@@ -78,8 +78,7 @@ make_binary_release() {
fi
# enable release profile here (to check for the maven version)
- tools/change-scala-version.sh ${SCALA_VERSION}
- $MVN clean package $FLAGS -Prelease -pl
flink-shaded-hadoop/flink-shaded-hadoop2-uber,flink-dist -am -Dgpg.skip
-Dcheckstyle.skip=true -DskipTests -Dmaven.test.skip=true
+ $MVN clean package $FLAGS -Prelease -pl flink-dist -am -Dgpg.skip
-Dcheckstyle.skip=true -DskipTests
cd flink-dist/target/flink-*-bin/
tar czf "${dir_name}.tgz" flink-*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> create_binary_release.sh is broken
> ----------------------------------
>
> Key: FLINK-10772
> URL: https://issues.apache.org/jira/browse/FLINK-10772
> Project: Flink
> Issue Type: Bug
> Components: Build System
> Affects Versions: 1.6.2, 1.7.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> The {{create_binary_release.sh}} is broken because it calls a script which
> does not exist. In fact, this script no longer needs to be called.
> Moreover, the build fails because we skip the compilation and packaging of
> test dependencies via {{-Dmaven.test.skip=true}}. The problem is that test
> dependencies are still being resolved if this property is specified. See
> MJAR-138 for more information.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
