[
https://issues.apache.org/jira/browse/FLINK-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676257#comment-16676257
]
ASF GitHub Bot commented on FLINK-10733:
----------------------------------------
yanghua opened a new pull request #7030: [FLINK-10733] Misleading
clean_log_files() in common.sh
URL: https://github.com/apache/flink/pull/7030
## What is the purpose of the change
*Fix misleading clean_log_files() in common.sh*
## Brief change log
- *Fix misleading clean_log_files() in common.sh*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe
tests)*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs
/ **not documented**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Misleading clean_log_files() in common.sh
> -----------------------------------------
>
> Key: FLINK-10733
> URL: https://issues.apache.org/jira/browse/FLINK-10733
> Project: Flink
> Issue Type: Bug
> Components: E2E Tests
> Affects Versions: 1.6.2
> Reporter: Kostas Kloudas
> Assignee: vinoyang
> Priority: Major
> Labels: pull-request-available
>
> In the `common.sh` base script of the end-to-end tests, there is a
> `clean_stdout_files` which cleans only the `*.out` files and a
> `clean_log_files` which cleans *both* `*.log` and `*.out` files.
> Given the current behavior that at the end of a test, the logs are checked
> and if there are exceptions (even expected ones but not whitelisted), the
> tests fails, some tests chose to call the `clean_log_files` so that
> exceptions are ignored. In this case, also `*.out` files are cleaned so if a
> test was checking for errors in the `.out` files, then the test will falsely
> pass.
> The solution is as simple as renaming the method to something more
> descriptive like `clean_logs_and_output_files`, but doing so, also includes
> checking if any existing tests were falsely passing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
