[
https://issues.apache.org/jira/browse/FLINK-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681064#comment-16681064
]
ASF GitHub Bot commented on FLINK-10733:
----------------------------------------
zentol closed pull request #7030: [FLINK-10733] Misleading clean_log_files() in
common.sh
URL: https://github.com/apache/flink/pull/7030
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/flink-end-to-end-tests/test-scripts/common.sh
b/flink-end-to-end-tests/test-scripts/common.sh
index 4f628fc6d12..9e0ed18dd6f 100644
--- a/flink-end-to-end-tests/test-scripts/common.sh
+++ b/flink-end-to-end-tests/test-scripts/common.sh
@@ -631,11 +631,6 @@ function clean_stdout_files {
echo "Deleted all stdout files under ${FLINK_DIR}/log/"
}
-function clean_log_files {
- rm ${FLINK_DIR}/log/*
- echo "Deleted all files under ${FLINK_DIR}/log/"
-}
-
# Expect a string to appear in the log files of the task manager before a
given timeout
# $1: expected string
# $2: timeout in seconds
diff --git a/flink-end-to-end-tests/test-scripts/test-runner-common.sh
b/flink-end-to-end-tests/test-scripts/test-runner-common.sh
index 0e56d2ac250..1db717251b6 100644
--- a/flink-end-to-end-tests/test-scripts/test-runner-common.sh
+++ b/flink-end-to-end-tests/test-scripts/test-runner-common.sh
@@ -83,7 +83,8 @@ function cleanup_proc {
# Cleans up all temporary folders and files
function cleanup_tmp_files {
- clean_log_files
+ rm ${FLINK_DIR}/log/*
+ echo "Deleted all files under ${FLINK_DIR}/log/"
rm -rf ${TEST_DATA_DIR} 2> /dev/null
echo "Deleted ${TEST_DATA_DIR}"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Misleading clean_log_files() in common.sh
> -----------------------------------------
>
> Key: FLINK-10733
> URL: https://issues.apache.org/jira/browse/FLINK-10733
> Project: Flink
> Issue Type: Bug
> Components: E2E Tests
> Affects Versions: 1.6.2
> Reporter: Kostas Kloudas
> Assignee: vinoyang
> Priority: Major
> Labels: pull-request-available
>
> In the `common.sh` base script of the end-to-end tests, there is a
> `clean_stdout_files` which cleans only the `*.out` files and a
> `clean_log_files` which cleans *both* `*.log` and `*.out` files.
> Given the current behavior that at the end of a test, the logs are checked
> and if there are exceptions (even expected ones but not whitelisted), the
> tests fails, some tests chose to call the `clean_log_files` so that
> exceptions are ignored. In this case, also `*.out` files are cleaned so if a
> test was checking for errors in the `.out` files, then the test will falsely
> pass.
> The solution is as simple as renaming the method to something more
> descriptive like `clean_logs_and_output_files`, but doing so, also includes
> checking if any existing tests were falsely passing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
