[
https://issues.apache.org/jira/browse/FLINK-10768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677099#comment-16677099
]
ASF GitHub Bot commented on FLINK-10768:
----------------------------------------
bowenli86 commented on issue #7011: [FLINK-10768][Table & SQL] Move external
catalog related code from TableEnvironment to CatalogManager
URL: https://github.com/apache/flink/pull/7011#issuecomment-436350350
holding on this PR as there are some related discussion going on at[ the
design
doc](https://docs.google.com/document/d/1SkppRD_rE3uOKSN-LuZCqn4f7dz0zW5aa6T_hBZq5_o/edit)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Move external catalog related code from TableEnvironment to CatalogManager
> --------------------------------------------------------------------------
>
> Key: FLINK-10768
> URL: https://issues.apache.org/jira/browse/FLINK-10768
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Bowen Li
> Assignee: Bowen Li
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.8.0
>
>
> Add a new CatalogManager class and port existing Calcite-directly-related
> code from TableEnvironment into CatalogManager.
> Background: there are two parallel efforts going on right now - FLINK-10686,
> driven by Timo, includes moving external catalogs APIs from flink-table to
> flink-table-common, also from Scala to Java; FLINK-10744 I'm working on right
> now to integrate Flink with Hive and enhance external catalog functionality.
> As discussed with @twalthr in FLINK-10689, we'd better parallelize these
> efforts while introducing minimal overhead for integrating them later. Our
> agreed way is to writing new code/feature related to external catalogs/hive
> in Java in flink-table first then move to other module like
> flink-table-common, this way we can minimize migration efforts. If existing
> classes are modified for a feature we can start migrating them to Java in a
> separate commit first and then perform the actual feature changes, and
> migrated classes can be placed in flink-table/src/main/java until we find a
> better module structure.
> Thus, this is NOT a feature, but purely refactor, thus no new functions
> should be introduced. It acts the pre-requisite for FLINK-10698
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
