NicoK commented on issue #6705: [FLINK-10356][network] add sanity checks to SpillingAdaptiveSpanningRecordDeserializer URL: https://github.com/apache/flink/pull/6705#issuecomment-436356439 Thanks @zhijiangW and @pnowojski for the reviews. I have addressed the comments and committed some changes. Please have a look whether these look better to you. I'm honestly not sure the additional code in the tests is worth the de-duplication...but maybe it is better readable now.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
