[
https://issues.apache.org/jira/browse/FLINK-9002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678203#comment-16678203
]
ASF GitHub Bot commented on FLINK-9002:
---------------------------------------
dawidwys commented on a change in pull request #7041: [FLINK-9002] [e2e] Add
operators with input type that goes through Avro serialization
URL: https://github.com/apache/flink/pull/7041#discussion_r231493564
##########
File path:
flink-end-to-end-tests/flink-datastream-allround-test/src/main/java/org/apache/flink/streaming/tests/DataStreamAllroundTestProgram.java
##########
@@ -143,6 +148,30 @@ public void apply(Integer integer, TimeWindow window,
Iterable<Event> input, Col
}
}).name(TIME_WINDOW_OPER_NAME);
+ // test operator input serialization with Avro specific records
as the input type
+ eventStream3 = testSpecificOperatorInputTypeSerialization(
+ eventStream3,
+ in -> new AvroEvent(in.getKey(), in.getEventTime(),
in.getSequenceNumber(), in.getPayload()),
+ in -> new Event(in.getKey(), in.getEventTime(),
in.getSequenceNumber(), in.getPayload()),
+ AvroEvent::getKey,
+ "Avro (Specific)");
+
+ // test operator input serialization with Avro generic records
as the input type
+ eventStream3 = testSpecificOperatorInputTypeSerialization(
+ eventStream3,
+ in -> {
+ GenericRecord record = new
GenericData.Record(AvroEvent.SCHEMA$);
Review comment:
Could we use `GenericRecordBuilder` here? I think it is a safer way to
construct `GenericRecord`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add operators with input type that goes through Avro serialization (with
> schema/generic)
> -----------------------------------------------------------------------------------------
>
> Key: FLINK-9002
> URL: https://issues.apache.org/jira/browse/FLINK-9002
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
> Affects Versions: 1.5.0
> Reporter: Stefan Richter
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
