[ 
https://issues.apache.org/jira/browse/FLINK-9002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678201#comment-16678201
 ] 

ASF GitHub Bot commented on FLINK-9002:
---------------------------------------

dawidwys commented on a change in pull request #7041: [FLINK-9002] [e2e] Add 
operators with input type that goes through Avro serialization
URL: https://github.com/apache/flink/pull/7041#discussion_r231493871
 
 

 ##########
 File path: 
flink-end-to-end-tests/flink-datastream-allround-test/src/main/java/org/apache/flink/streaming/tests/DataStreamAllroundTestJobFactory.java
 ##########
 @@ -455,4 +457,15 @@ static boolean isSimulateFailures(ParameterTool pt) {
                        listStateGenerator,
                        listStateDescriptor);
        }
+
+       static <T> DataStream<Event> testSpecificOperatorInputTypeSerialization(
+                       DataStream<Event> streamToConvert,
+                       MapFunction<Event, T> convertToInputType,
+                       MapFunction<T, Event> convertFromInputType,
+                       KeySelector<T, Integer> inputTypeKeySelector,
+                       String inputTypeId) {
+
+               DataStream<T> convertedStream = 
streamToConvert.map(convertToInputType);
+               return 
convertedStream.keyBy(inputTypeKeySelector).map(convertFromInputType).name("InputTypeSerializationTestOperator-"
 + inputTypeId);
 
 Review comment:
   Could we add a quick node why the `keyBy` is needed? It is so that the 
functions are not chained, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add operators with input type that goes through Avro serialization (with 
> schema/generic) 
> -----------------------------------------------------------------------------------------
>
>                 Key: FLINK-9002
>                 URL: https://issues.apache.org/jira/browse/FLINK-9002
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Tests
>    Affects Versions: 1.5.0
>            Reporter: Stefan Richter
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to