Github user sachingoel0101 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/861#discussion_r37528613
  
    --- Diff: 
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/MLUtils.scala ---
    @@ -119,4 +123,65 @@ object MLUtils {
     
         stringRepresentation.writeAsText(filePath)
       }
    +
    +  /** Create a [[ContinuousHistogram]] from the input data
    +    *
    +    * @param bins Number of bins required
    +    * @param data input [[DataSet]] of [[Double]]
    +    * @return [[ContinuousHistogram]] over the data
    +    */
    +  def createContinuousHistogram(data: DataSet[Double], bins: Int): 
DataSet[ContinuousHistogram] = {
    +    val min = data.reduce((x, y) => Math.min(x, y))
    +    val max = data.reduce((x, y) => Math.max(x, y))
    +
    +    val stats = min.mapWithBcVariable(max) {
    +      (minimum, maximum) => (minimum - 2 * (maximum - minimum), maximum + 
2 * (maximum - minimum))
    +    }
    +
    +    data.mapPartition(new RichMapPartitionFunction[Double, 
ContinuousHistogram] {
    +      var statistics: (Double, Double) = _
    +
    +      override def open(configuration: Configuration): Unit = {
    +        statistics = 
getRuntimeContext.getBroadcastVariable(HISTOGRAM_STATS).get(0)
    +        val minimum = statistics._1
    +        val maximum = statistics._2
    +        statistics = (minimum - 2 * (maximum - minimum), maximum + 2 * 
(maximum - minimum))
    --- End diff --
    
    No. The one in 148 shouldn't be here. This is actually intended to be added 
in the next commit with Column-wise statistics. I'll remove it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to