Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/861#discussion_r37528781
  
    --- Diff: 
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/MLUtils.scala ---
    @@ -119,4 +123,65 @@ object MLUtils {
     
         stringRepresentation.writeAsText(filePath)
       }
    +
    +  /** Create a [[ContinuousHistogram]] from the input data
    +    *
    +    * @param bins Number of bins required
    +    * @param data input [[DataSet]] of [[Double]]
    +    * @return [[ContinuousHistogram]] over the data
    +    */
    +  def createContinuousHistogram(data: DataSet[Double], bins: Int): 
DataSet[ContinuousHistogram] = {
    +    val min = data.reduce((x, y) => Math.min(x, y))
    +    val max = data.reduce((x, y) => Math.max(x, y))
    +
    +    val stats = min.mapWithBcVariable(max) {
    +      (minimum, maximum) => (minimum - 2 * (maximum - minimum), maximum + 
2 * (maximum - minimum))
    +    }
    +
    +    data.mapPartition(new RichMapPartitionFunction[Double, 
ContinuousHistogram] {
    --- End diff --
    
    We could write this a little bit more scalaesque if we introduce a 
`mapPartitionWithBcVariable` function.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to