[
https://issues.apache.org/jira/browse/FLINK-10820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681106#comment-16681106
]
ASF GitHub Bot commented on FLINK-10820:
----------------------------------------
Clarkkkkk commented on issue #7051: [FLINK-10820][network] Simplify the
RebalancePartitioner implementation
URL: https://github.com/apache/flink/pull/7051#issuecomment-437295933
Codes LGTM. Since RebalancePartitioner and RoundRobinPartitioner are
duplicate right now, I would vote for keeping RoundRobinPartitioner whose name
is more intuitive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Simplify the RebalancePartitioner implementation
> ------------------------------------------------
>
> Key: FLINK-10820
> URL: https://issues.apache.org/jira/browse/FLINK-10820
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Affects Versions: 1.8.0
> Reporter: zhijiang
> Assignee: zhijiang
> Priority: Minor
> Labels: pull-request-available
>
> The current {{RebalancePartitioner}} implementations seems a little hacky for
> selecting a random number as the first channel index, and the following
> selections based on this random index in round-robin fashion.
> We can define a constant as the first channel index to make the
> implementation simple and readable. To do so, it will not change the
> rebalance semantics.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
