[
https://issues.apache.org/jira/browse/FLINK-10634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683486#comment-16683486
]
ASF GitHub Bot commented on FLINK-10634:
----------------------------------------
kl0u commented on a change in pull request #7056: [FLINK-10634][metrics][rest]
Add metrics availability e2e test
URL: https://github.com/apache/flink/pull/7056#discussion_r232592152
##########
File path:
flink-end-to-end-tests/flink-metrics-availability-test/src/test/java/org/pache/flink/metrics/tests/MetricsAvailabilityITCase.java
##########
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.pache.flink.metrics.tests;
+
+import org.apache.flink.api.common.time.Deadline;
+import org.apache.flink.api.common.time.Time;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.runtime.clusterframework.types.ResourceID;
+import org.apache.flink.runtime.concurrent.FutureUtils;
+import org.apache.flink.runtime.concurrent.ScheduledExecutorServiceAdapter;
+import org.apache.flink.runtime.rest.RestClient;
+import org.apache.flink.runtime.rest.RestClientConfiguration;
+import org.apache.flink.runtime.rest.messages.EmptyMessageParameters;
+import org.apache.flink.runtime.rest.messages.EmptyRequestBody;
+import
org.apache.flink.runtime.rest.messages.job.metrics.JobManagerMetricsHeaders;
+import
org.apache.flink.runtime.rest.messages.job.metrics.JobManagerMetricsMessageParameters;
+import
org.apache.flink.runtime.rest.messages.job.metrics.MetricCollectionResponseBody;
+import
org.apache.flink.runtime.rest.messages.job.metrics.TaskManagerMetricsHeaders;
+import
org.apache.flink.runtime.rest.messages.job.metrics.TaskManagerMetricsMessageParameters;
+import org.apache.flink.runtime.rest.messages.taskmanager.TaskManagerInfo;
+import org.apache.flink.runtime.rest.messages.taskmanager.TaskManagersHeaders;
+import org.apache.flink.runtime.rest.messages.taskmanager.TaskManagersInfo;
+import org.apache.flink.tests.util.FlinkDistribution;
+import org.apache.flink.util.TestLogger;
+import org.apache.flink.util.function.SupplierWithException;
+
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.Rule;
+import org.junit.Test;
+
+import javax.annotation.Nullable;
+
+import java.io.IOException;
+import java.time.Duration;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.function.Predicate;
+import java.util.stream.Collectors;
+
+/**
+ * End-to-end test for the availability of metrics.
+ */
+public class MetricsAvailabilityITCase extends TestLogger {
+
+ private static final String HOST = "localhost";
+ private static final int PORT = 8081;
+
+ @Rule
+ public final FlinkDistribution dist = new FlinkDistribution();
+
+ @Nullable
+ private static ScheduledExecutorService scheduledExecutorService = null;
+
+ @BeforeClass
+ public static void startExecutor() {
+ scheduledExecutorService = Executors.newScheduledThreadPool(4);
+ }
+
+ @AfterClass
+ public static void shutdownExecutor() {
+ if (scheduledExecutorService != null) {
+ scheduledExecutorService.shutdown();
+ }
+ }
+
+ @Test
+ public void testReporter() throws Exception {
+ dist.startFlinkCluster();
+
+ final RestClient restClient = new
RestClient(RestClientConfiguration.fromConfiguration(new Configuration()),
scheduledExecutorService);
+
+ checkJobManagerMetricAvailability(restClient);
+
+ final Collection<ResourceID> taskManagerIds =
getTaskManagerIds(restClient);
+
+ for (final ResourceID taskManagerId : taskManagerIds) {
+ checkTaskManagerMetricAvailability(restClient,
taskManagerId);
+ }
+ }
+
+ private static void checkJobManagerMetricAvailability(final RestClient
restClient) throws Exception {
+ final JobManagerMetricsHeaders headers =
JobManagerMetricsHeaders.getInstance();
+ final JobManagerMetricsMessageParameters parameters =
headers.getUnresolvedMessageParameters();
+
parameters.metricsFilterParameter.resolve(Collections.singletonList("numRegisteredTaskManagers"));
+
+ fetchMetric(() ->
+ restClient.sendRequest(HOST, PORT, headers,
parameters, EmptyRequestBody.getInstance()),
+ getMetricNamePredicate("numRegisteredTaskManagers"));
+ }
+
+ private static Collection<ResourceID> getTaskManagerIds(final
RestClient restClient) throws Exception {
+ final TaskManagersHeaders headers =
TaskManagersHeaders.getInstance();
+
+ final TaskManagersInfo response = fetchMetric(() ->
+ restClient.sendRequest("localhost",
+ 8081,
+ headers,
+ EmptyMessageParameters.getInstance(),
+ EmptyRequestBody.getInstance()),
+ taskManagersInfo ->
!taskManagersInfo.getTaskManagerInfos().isEmpty());
+
+ return response.getTaskManagerInfos().stream()
+ .map(TaskManagerInfo::getResourceId)
+ .collect(Collectors.toList());
+ }
+
+ private static void checkTaskManagerMetricAvailability(final RestClient
restClient, final ResourceID taskManagerId) throws Exception {
+ final TaskManagerMetricsHeaders headers =
TaskManagerMetricsHeaders.getInstance();
+ final TaskManagerMetricsMessageParameters parameters =
headers.getUnresolvedMessageParameters();
+ parameters.taskManagerIdParameter.resolve(taskManagerId);
+
parameters.metricsFilterParameter.resolve(Collections.singletonList("Status.Network.TotalMemorySegments"));
+
+ fetchMetric(() ->
+ restClient.sendRequest(HOST, PORT, headers,
parameters, EmptyRequestBody.getInstance()),
+
getMetricNamePredicate("Status.Network.TotalMemorySegments"));
+ }
+
+ private static <X> X fetchMetric(final
SupplierWithException<CompletableFuture<X>, IOException> clientOperation, final
Predicate<X> predicate) throws InterruptedException, ExecutionException,
TimeoutException {
+ final CompletableFuture<X> responseFuture =
FutureUtils.retrySuccesfulWithDelay(() -> {
Review comment:
Typo `retrySuccesfulWithDelay` -> `retrySucces**s**fulWithDelay`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> End-to-end test: Metrics accessible via REST API
> ------------------------------------------------
>
> Key: FLINK-10634
> URL: https://issues.apache.org/jira/browse/FLINK-10634
> Project: Flink
> Issue Type: Sub-task
> Components: E2E Tests, Metrics, REST
> Affects Versions: 1.7.0
> Reporter: Till Rohrmann
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
>
> Verify that Flink's metrics can be accessed via the REST API.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
