zentol commented on issue #7056: [FLINK-10634][metrics][rest] Add metrics 
availability e2e test
URL: https://github.com/apache/flink/pull/7056#issuecomment-438618845
 
 
   > Also it is worth adding a line in the README for the Prometheus and this 
test that states that you can run them locally with mvn clean verify 
-De2e-metrics -DdistDir=YOUR_DIR
   
   I don't really want to add these instructions right now since they are quite 
disconnected from the actual test. How the profile is called is determined in 
the pom, what the distDir property is called in the `FlinkDistribution`. I'd 
like to avoid them becoming out-dated, i.e. simply wrong.
   
   I have some ideas on how to better document how to run them, so that if the 
test is not executed you get a message saying what was missing. E.g. "Test was 
skipped since property 'e2e-metrics' was not specified."
   This way you would simply _try_ running them and get the infos on how to do 
it right there.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to