[jira] [Commented] (FLINK-10642) CodeGen split fields errors when maxGeneratedCodeLength equals 1

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-10642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689453#comment-16689453
 ] 

ASF GitHub Bot commented on FLINK-10642:
----------------------------------------

asfgit closed pull request #6900: [FLINK-10642][table] fix CodeGen split fields 
errors in special config
URL: https://github.com/apache/flink/pull/6900
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
 
b/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
index 19e030b4c0a..8f9913bdfaa 100644
--- 
a/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
+++ 
b/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
@@ -1057,13 +1057,13 @@ abstract class CodeGenerator(
 
         // declaration
         val resultTypeTerm = primitiveTypeTermForTypeInfo(expr.resultType)
-        if (nullCheck) {
+        if (nullCheck && !expr.nullTerm.equals(NEVER_NULL) && 
!expr.nullTerm.equals(ALWAYS_NULL)) {
           reusableMemberStatements.add(s"private boolean ${expr.nullTerm};")
         }
         reusableMemberStatements.add(s"private $resultTypeTerm 
${expr.resultTerm};")
 
         // assignment
-        if (nullCheck) {
+        if (nullCheck && !expr.nullTerm.equals(NEVER_NULL) && 
!expr.nullTerm.equals(ALWAYS_NULL)) {
           reusablePerRecordStatements.add(s"this.${expr.nullTerm} = 
${expr.nullTerm};")
         }
         reusablePerRecordStatements.add(s"this.${expr.resultTerm} = 
${expr.resultTerm};")
diff --git 
a/flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/table/CalcITCase.scala
 
b/flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/table/CalcITCase.scala
index b161eeda43c..4e880eeaf3b 100644
--- 
a/flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/table/CalcITCase.scala
+++ 
b/flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/table/CalcITCase.scala
@@ -578,6 +578,22 @@ class CalcITCase(
     val expected = List("a,a,d,d,e,e", "x,x,z,z,z,z").mkString("\n")
     TestBaseUtils.compareResultAsText(results.asJava, expected)
   }
+
+  @Test
+  def testSplitFeildsOnCustomType(): Unit = {
+    val env = ExecutionEnvironment.getExecutionEnvironment
+    val tEnv = TableEnvironment.getTableEnvironment(env, config)
+    tEnv.getConfig.setMaxGeneratedCodeLength(1)  // splits fields
+
+    val ds = CollectionDataSets.getCustomTypeDataSet(env)
+    val filterDs = ds.toTable(tEnv, 'myInt as 'i, 'myLong as 'l, 'myString as 
's)
+      .filter( 's.like("%a%") && 's.charLength > 12)
+      .select('i, 'l, 's.charLength)
+
+    val expected = "3,3,25\n" + "3,5,14\n"
+    val results = filterDs.toDataSet[Row].collect()
+    TestBaseUtils.compareResultAsText(results.asJava, expected)
+  }
 }
 
 object CalcITCase {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> CodeGen split fields errors when maxGeneratedCodeLength equals 1
> ----------------------------------------------------------------
>
>                 Key: FLINK-10642
>                 URL: https://issues.apache.org/jira/browse/FLINK-10642
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>    Affects Versions: 1.6.1
>            Reporter: xueyu
>            Assignee: xueyu
>            Priority: Major
>              Labels: pull-request-available
>
> Several tests error in special config when setting maxGeneratedCodeLength 1. 
> e.g.
>   CalcITCase.testFilterOnCustomType:260 ? InvalidProgram Table program cannot 
> be...
>   JavaTableEnvironmentITCase.testAsFromAndToPojo:394 ? InvalidProgram Table 
> prog...
>   JavaTableEnvironmentITCase.testAsFromAndToPrivateFieldPojo:421 ? 
> InvalidProgram
>   JavaTableEnvironmentITCase.testAsFromPojo:288 ? InvalidProgram Table 
> program c...
>   JavaTableEnvironmentITCase.testAsFromPrivateFieldsPojo:366 ? InvalidProgram 
> Ta...
>   JavaTableEnvironmentITCase.testAsWithPojoAndGenericTypes:453 ? 
> InvalidProgram ...
>   TimeAttributesITCase.testPojoSupport:566 ? JobExecution Job execution 
> failed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)