[ 
https://issues.apache.org/jira/browse/FLINK-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691205#comment-16691205
 ] 

ASF GitHub Bot commented on FLINK-9555:
---------------------------------------

sunjincheng121 commented on a change in pull request #7121: [FLINK-9555]Support 
table api in scala shell
URL: https://github.com/apache/flink/pull/7121#discussion_r234481358
 
 

 ##########
 File path: flink-dist/pom.xml
 ##########
 @@ -319,7 +319,6 @@ under the License.
                        <groupId>org.apache.flink</groupId>
                        
<artifactId>flink-table_${scala.binary.version}</artifactId>
                        <version>${project.version}</version>
-                       <scope>provided</scope>
 
 Review comment:
   I suggest that revert this change, because `flink-dist` is the whole release 
strategy of flink. At present, we package the `flink-table` module to the `opt` 
directory. The minimum change I suggest is to modify the scala-shell CLASSPATH 
and include `opt/opt/flink-tableXXX.jar` in the CLASSPATH, to support tables in 
`scala-shell`, What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Support table api in scala shell
> --------------------------------
>
>                 Key: FLINK-9555
>                 URL: https://issues.apache.org/jira/browse/FLINK-9555
>             Project: Flink
>          Issue Type: New Feature
>          Components: Scala Shell
>    Affects Versions: 1.5.0
>            Reporter: Jeff Zhang
>            Assignee: shuiqiangchen
>            Priority: Major
>              Labels: pull-request-available
>
> It would be nice to have table api available in scala shell so that user can 
> experience table api in interactive way. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to