[
https://issues.apache.org/jira/browse/FLINK-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691206#comment-16691206
]
ASF GitHub Bot commented on FLINK-9555:
---------------------------------------
sunjincheng121 commented on a change in pull request #7121: [FLINK-9555]Support
table api in scala shell
URL: https://github.com/apache/flink/pull/7121#discussion_r234478589
##########
File path:
flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkILoop.scala
##########
@@ -96,6 +97,12 @@ class FlinkILoop(
(scalaBenv,scalaSenv)
}
+ val (scalaBTEnv: BatchTableEnvironment, scalaSTEnv: StreamTableEnvironment)
= {
Review comment:
I suggest that merge two local environment init logic as follows:
```
// local environment
val (
scalaBenv: ExecutionEnvironment,
scalaSenv: StreamExecutionEnvironment,
scalaBTabEnv: BatchTableEnvironment,
scalaSTabEnv: StreamTableEnvironment) = {
val scalaBenv = new ExecutionEnvironment(remoteBenv)
val scalaSenv = new StreamExecutionEnvironment(remoteSenv)
val scalaBTabEnv = TableEnvironment.getTableEnvironment(scalaBenv)
val scalaSTabEnv = TableEnvironment.getTableEnvironment(scalaSenv)
(scalaBenv, scalaSenv, scalaBTabEnv, scalaSTabEnv)
}```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support table api in scala shell
> --------------------------------
>
> Key: FLINK-9555
> URL: https://issues.apache.org/jira/browse/FLINK-9555
> Project: Flink
> Issue Type: New Feature
> Components: Scala Shell
> Affects Versions: 1.5.0
> Reporter: Jeff Zhang
> Assignee: shuiqiangchen
> Priority: Major
> Labels: pull-request-available
>
> It would be nice to have table api available in scala shell so that user can
> experience table api in interactive way.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
