[
https://issues.apache.org/jira/browse/FLINK-10924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694633#comment-16694633
]
ASF GitHub Bot commented on FLINK-10924:
----------------------------------------
zentol commented on a change in pull request #7143: [FLINK-10924] [javadoc]
StreamExecutionEnvironment method javadocs in…
URL: https://github.com/apache/flink/pull/7143#discussion_r235362545
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
##########
@@ -1261,7 +1261,7 @@ public TimeCharacteristic getStreamTimeCharacteristic() {
/**
* Creates a new data stream that contains the strings received
infinitely from a socket. Received strings are
- * decoded by the system's default character set, using"\n" as
delimiter. The reader is terminated immediately when
Review comment:
this method does is not defaulting to UTF-8.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> StreamExecutionEnvironment method javadocs incorrect in regards to used
> charset
> -------------------------------------------------------------------------------
>
> Key: FLINK-10924
> URL: https://issues.apache.org/jira/browse/FLINK-10924
> Project: Flink
> Issue Type: Bug
> Components: Documentation, Streaming
> Affects Versions: 1.3.3, 1.4.2, 1.5.5, 1.6.2, 1.7.0
> Reporter: Chesnay Schepler
> Assignee: TisonKun
> Priority: Major
> Labels: pull-request-available
>
> Various methods of the {{StreamExecutionEnvironment}} (like
> [readTextFile|https://github.com/apache/flink/blob/master/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java#L939])
> are documented to be using the system's default charset if none is specified.
> This is incorrect as they default to UTF-8 instead. The javadocs should be
> updated to reflect this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
