twalthr commented on a change in pull request #7079: [FLINK-10845][table]
Support multiple different DISTINCT aggregates for batch
URL: https://github.com/apache/flink/pull/7079#discussion_r235670192
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala
##########
@@ -1288,7 +1295,8 @@ object ScalarOperators {
nullCheck: Boolean,
resultType: TypeInformation[_],
left: GeneratedExpression,
- right: GeneratedExpression)
+ right: GeneratedExpression,
+ compareNull: Boolean)
Review comment:
@xueyumusic After looking at the amount of changes, I would suggest to leave
`generateOperatorIfNotNull` untouched. This method is correct as it is. If you
need some special null comparing logic. We can create a specialized method only
for `equals`. We could create a method `generateDistinctFrom` that wraps
`generateEquals`. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
