[ 
https://issues.apache.org/jira/browse/FLINK-9461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696693#comment-16696693
 ] 

vinoyang commented on FLINK-9461:
---------------------------------

hi [~twalthr]  Thank you for your explanation of the context.
I should confirm with you to make sure I have not misunderstood what you mean. 
Whether we can migrate the classes to flink-table-common, which are originally 
in flink-table but are dependent on flink*_-_*connector*_-_*kafka, such as 
StreamTableSource. Then make flink-connector-kafka directly dependent on 
flink-table-common instead of flink-table. right? 

> Disentangle flink-connector-kafka from flink-table and flink-json
> -----------------------------------------------------------------
>
>                 Key: FLINK-9461
>                 URL: https://issues.apache.org/jira/browse/FLINK-9461
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Build System
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: vinoyang
>            Priority: Major
>             Fix For: 1.8.0
>
>
> Currently, the {{flink-connector-kafka}} module has a dependency on 
> {{flink-table}} and {{flink-json}}. The reason seems to be that the module 
> contains the {{KafkaJsonTableSource}} and {{KafkaJsonTableSink}}. Even though 
> the {{flink-table}} and {{flink-json}} dependency are marked as optional, the 
> {{flink-connector-kafka}} will still contain the table sources and sinks. I 
> think this is not a clean design.
> I would propose to move the table sources and sinks into a dedicated module 
> which depends on {{flink-connector-kafka}}. That way we would better separate 
> dependencies and could remove {{flink-table}} and {{flink-json}} from 
> {{flink-connector-kafka}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to