[
https://issues.apache.org/jira/browse/FLINK-9461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697054#comment-16697054
]
Timo Walther edited comment on FLINK-9461 at 11/23/18 12:09 PM:
----------------------------------------------------------------
Yes, this is the way to go. Feel free to start porting interfaces that
logically belong into the a common module according to the design document.
Let's discuss again if you see more and more classes are pulled in
transitively. For example, we cannot port {{FilterableTableSource}} because it
would pull in expressions but I think Kafka is not using it.
was (Author: twalthr):
Yes, this is the way to go. Feel free to start porting interfaces that
logically belong into the a common module according to the design document.
Let's discuss again if you see more and more classes are pulled in
transitively. For example, we cannot port \{{FilterableTableSource}} but I
think Kafka is not using it.
> Disentangle flink-connector-kafka from flink-table and flink-json
> -----------------------------------------------------------------
>
> Key: FLINK-9461
> URL: https://issues.apache.org/jira/browse/FLINK-9461
> Project: Flink
> Issue Type: Sub-task
> Components: Build System
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: vinoyang
> Priority: Major
> Fix For: 1.8.0
>
>
> Currently, the {{flink-connector-kafka}} module has a dependency on
> {{flink-table}} and {{flink-json}}. The reason seems to be that the module
> contains the {{KafkaJsonTableSource}} and {{KafkaJsonTableSink}}. Even though
> the {{flink-table}} and {{flink-json}} dependency are marked as optional, the
> {{flink-connector-kafka}} will still contain the table sources and sinks. I
> think this is not a clean design.
> I would propose to move the table sources and sinks into a dedicated module
> which depends on {{flink-connector-kafka}}. That way we would better separate
> dependencies and could remove {{flink-table}} and {{flink-json}} from
> {{flink-connector-kafka}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
