[
https://issues.apache.org/jira/browse/FLINK-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698278#comment-16698278
]
ASF GitHub Bot commented on FLINK-4173:
---------------------------------------
zentol opened a new pull request #7172: [FLINK-4173][metrics] Replace
assembly-plugin usage
URL: https://github.com/apache/flink/pull/7172
## What is the purpose of the change
With this PR we no longer use the `maven-assembly-plugin` for packaging
metric jars. This makes the remaining modules more consistent with other
reporter modules and makes license handling easier.
The ganglia-module has not been touched since it is due for removal anyway,
see #7169.
## Brief change log
* replace assembly-plugin usage for graphite reporter with shade-plugin
* remove bundling of dropwizard module in flink-dist
* reporters should bundle it instead (and our dropwizard reporter already
did)
* remove assembly-plugin usage in dropwizard module as the fat-jar is no
longer used
## Verifying this change
Manually verified that the contents in the dropwizard jar are identical.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace maven-assembly-plugin by maven-shade-plugin in flink-metrics
> --------------------------------------------------------------------
>
> Key: FLINK-4173
> URL: https://issues.apache.org/jira/browse/FLINK-4173
> Project: Flink
> Issue Type: Bug
> Components: Metrics
> Affects Versions: 1.1.0
> Reporter: Till Rohrmann
> Assignee: Chesnay Schepler
> Priority: Minor
> Labels: pull-request-available
>
> The modules {{flink-metrics-dropwizard}}, {{flink-metrics-ganglia}} and
> {{flink-metrics-graphite}} use the {{maven-assembly-plugin}} to build a fat
> jar. The resulting fat jar has the suffix {{jar-with-dependencies}}. In order
> to make the naming consistent with the rest of the system we should create a
> fat-jar without this suffix.
> Additionally we could replace the {{maven-assembly-plugin}} with the
> {{maven-shade-plugin}} to make it consistent with the rest of the system.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
