[
https://issues.apache.org/jira/browse/FLINK-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700485#comment-16700485
]
ASF GitHub Bot commented on FLINK-4173:
---------------------------------------
zentol closed pull request #7172: [FLINK-4173][metrics] Replace assembly-plugin
usage
URL: https://github.com/apache/flink/pull/7172
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/flink-dist/src/main/assemblies/opt.xml
b/flink-dist/src/main/assemblies/opt.xml
index ba459b1670e..0d9acf3c3ae 100644
--- a/flink-dist/src/main/assemblies/opt.xml
+++ b/flink-dist/src/main/assemblies/opt.xml
@@ -85,14 +85,7 @@
<!-- Metrics -->
<file>
-
<source>../flink-metrics/flink-metrics-dropwizard/target/flink-metrics-dropwizard-${project.version}-jar-with-dependencies.jar</source>
- <outputDirectory>opt/</outputDirectory>
-
<destName>flink-metrics-dropwizard-${project.version}.jar</destName>
- <fileMode>0644</fileMode>
- </file>
-
- <file>
-
<source>../flink-metrics/flink-metrics-graphite/target/flink-metrics-graphite-${project.version}-jar-with-dependencies.jar</source>
+
<source>../flink-metrics/flink-metrics-graphite/target/flink-metrics-graphite-${project.version}.jar</source>
<outputDirectory>opt/</outputDirectory>
<destName>flink-metrics-graphite-${project.version}.jar</destName>
<fileMode>0644</fileMode>
diff --git a/flink-metrics/flink-metrics-dropwizard/pom.xml
b/flink-metrics/flink-metrics-dropwizard/pom.xml
index 19da8472870..bdbb95d75d5 100644
--- a/flink-metrics/flink-metrics-dropwizard/pom.xml
+++ b/flink-metrics/flink-metrics-dropwizard/pom.xml
@@ -86,27 +86,4 @@ under the License.
</dependency>
</dependencies>
-
- <build>
- <plugins>
- <plugin>
- <artifactId>maven-assembly-plugin</artifactId>
- <version>2.4</version>
- <configuration>
- <descriptorRefs>
-
<descriptorRef>jar-with-dependencies</descriptorRef>
- </descriptorRefs>
- </configuration>
- <executions>
- <execution>
- <id>make-assembly</id>
- <phase>package</phase>
- <goals>
- <goal>single</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
</project>
diff --git a/flink-metrics/flink-metrics-graphite/pom.xml
b/flink-metrics/flink-metrics-graphite/pom.xml
index 03ba5364bd9..c8d1f8c8df5 100644
--- a/flink-metrics/flink-metrics-graphite/pom.xml
+++ b/flink-metrics/flink-metrics-graphite/pom.xml
@@ -69,20 +69,24 @@ under the License.
<build>
<plugins>
<plugin>
- <artifactId>maven-assembly-plugin</artifactId>
- <version>2.4</version>
- <configuration>
- <descriptorRefs>
-
<descriptorRef>jar-with-dependencies</descriptorRef>
- </descriptorRefs>
- </configuration>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
<executions>
<execution>
- <id>make-assembly</id>
+ <id>shade-flink</id>
<phase>package</phase>
<goals>
- <goal>single</goal>
+ <goal>shade</goal>
</goals>
+ <configuration>
+ <artifactSet>
+ <includes>
+
<include>org.apache.flink:flink-metrics-dropwizard</include>
+
<include>io.dropwizard.metrics:metrics-core</include>
+
<include>io.dropwizard.metrics:metrics-graphite</include>
+ </includes>
+ </artifactSet>
+ </configuration>
</execution>
</executions>
</plugin>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace maven-assembly-plugin by maven-shade-plugin in flink-metrics
> --------------------------------------------------------------------
>
> Key: FLINK-4173
> URL: https://issues.apache.org/jira/browse/FLINK-4173
> Project: Flink
> Issue Type: Bug
> Components: Metrics
> Affects Versions: 1.1.0
> Reporter: Till Rohrmann
> Assignee: Chesnay Schepler
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.5.6, 1.6.3, 1.7.0
>
>
> The modules {{flink-metrics-dropwizard}}, {{flink-metrics-ganglia}} and
> {{flink-metrics-graphite}} use the {{maven-assembly-plugin}} to build a fat
> jar. The resulting fat jar has the suffix {{jar-with-dependencies}}. In order
> to make the naming consistent with the rest of the system we should create a
> fat-jar without this suffix.
> Additionally we could replace the {{maven-assembly-plugin}} with the
> {{maven-shade-plugin}} to make it consistent with the rest of the system.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
