azagrebin commented on a change in pull request #6777: [FLINK-10461] [State
Backends, Checkpointing] Speed up download files when restore from DFS
URL: https://github.com/apache/flink/pull/6777#discussion_r236199821
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackend.java
##########
@@ -276,6 +312,12 @@ private RocksDBStateBackend(RocksDBStateBackend original,
Configuration config)
this.enableIncrementalCheckpointing =
original.enableIncrementalCheckpointing.resolveUndefined(
config.getBoolean(CheckpointingOptions.INCREMENTAL_CHECKPOINTS));
+ if (original.restoredThreadNum ==
CheckpointingOptions.CHECKPOINT_RESTORE_THREAD_NUM.defaultValue()) {
Review comment:
here we could initialise `restoredThreadNum` from `config` if
`original.restoredThreadNum` is -1 (undefined). Otherwise `restoredThreadNum` =
`original.restoredThreadNum`, similar to
`original.enableIncrementalCheckpointing.resolveUndefined`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
