[
https://issues.apache.org/jira/browse/FLINK-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14707979#comment-14707979
]
Martin Liesenberg commented on FLINK-2445:
------------------------------------------
Hi,
I have a question concerning the scope of the task. As I understand it the
HadoopOutputFormat* classes wrap access to the actual Hadoop OutputFormat
implementations and the tests should ensure that the methods of those
OutputFormat classes are called correctly - so far so good and stated in the
description as well.
Is it sufficient to create a mock object and assert that the methods are called
correctly? Judging from the HadoopOutputFormatBase class, the Hadoop
OutputFormat can implement (Job)Configurable, so I guess those cases would need
to be covered as well?
Best regards, Martin
> Add tests for HadoopOutputFormats
> ---------------------------------
>
> Key: FLINK-2445
> URL: https://issues.apache.org/jira/browse/FLINK-2445
> Project: Flink
> Issue Type: Test
> Components: Hadoop Compatibility, Tests
> Affects Versions: 0.10, 0.9.1
> Reporter: Fabian Hueske
> Labels: starter
>
> The HadoopOutputFormats and HadoopOutputFormatBase classes are not
> sufficiently covered by unit tests.
> We need tests that ensure that the methods of the wrapped Hadoop
> OutputFormats are correctly called.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
