[
https://issues.apache.org/jira/browse/FLINK-11004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16699980#comment-16699980
]
ASF GitHub Bot commented on FLINK-11004:
----------------------------------------
sunjincheng121 commented on a change in pull request #7175:
[FLINK-11004][Documentation] wrong ProcessWindowFunction.process argument in
window document
URL: https://github.com/apache/flink/pull/7175#discussion_r236533158
##########
File path: docs/dev/stream/operators/windows.md
##########
@@ -836,12 +836,12 @@ input
.reduce(
(r1: SensorReading, r2: SensorReading) => { if (r1.value > r2.value) r2
else r1 },
( key: String,
- window: TimeWindow,
+ context: Context,
Review comment:
`SideOutputITCase.scala#L213` works well due to create instance by `new`
keyword. But in the change of document we using the `Lambda` which can not be
reference the correct type. Please copy the document scala code to your IDE, I
think the compile error will appear. Hope your feedback. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Wrong ProcessWindowFunction.process argument in example of Incremental Window
> Aggregation with ReduceFunction
> -------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-11004
> URL: https://issues.apache.org/jira/browse/FLINK-11004
> Project: Flink
> Issue Type: Bug
> Components: Documentation
> Affects Versions: 1.4.2, 1.5.5, 1.6.2
> Reporter: Yuanyang Wu
> Priority: Major
> Labels: pull-request-available
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> [https://ci.apache.org/projects/flink/flink-docs-release-1.6/dev/stream/operators/windows.html#incremental-window-aggregation-with-reducefunction]
> Example use wrong "window" argument in process()
> {{JAVA example}}
> {{- out.collect(new Tuple2<Long,
> SensorReading>({color:#d04437}window{color}.getStart(), min));}}
> {{+ out.collect(new Tuple2<Long,
> SensorReading>({color:#14892c}context.window(){color}.getStart(), min));}}
>
> {{Scala example 2nd argument should be context:Context instead of window}}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
