[
https://issues.apache.org/jira/browse/FLINK-11004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701580#comment-16701580
]
ASF GitHub Bot commented on FLINK-11004:
----------------------------------------
asfgit closed pull request #7175: [FLINK-11004][Documentation] wrong
ProcessWindowFunction.process argument in window document
URL: https://github.com/apache/flink/pull/7175
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/docs/dev/stream/operators/windows.md
b/docs/dev/stream/operators/windows.md
index bebc5dd260e..cd47ed567fc 100644
--- a/docs/dev/stream/operators/windows.md
+++ b/docs/dev/stream/operators/windows.md
@@ -819,7 +819,7 @@ private static class MyProcessWindowFunction
Iterable<SensorReading> minReadings,
Collector<Tuple2<Long, SensorReading>> out) {
SensorReading min = minReadings.iterator().next();
- out.collect(new Tuple2<Long, SensorReading>(window.getStart(), min));
+ out.collect(new Tuple2<Long, SensorReading>(context.window().getStart(),
min));
}
}
@@ -836,12 +836,12 @@ input
.reduce(
(r1: SensorReading, r2: SensorReading) => { if (r1.value > r2.value) r2
else r1 },
( key: String,
- window: TimeWindow,
+ context: ProcessWindowFunction[_, _, _, TimeWindow]#Context,
minReadings: Iterable[SensorReading],
out: Collector[(Long, SensorReading)] ) =>
{
val min = minReadings.iterator.next()
- out.collect((window.getStart, min))
+ out.collect((context.window.getStart, min))
}
)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Wrong ProcessWindowFunction.process argument in example of Incremental Window
> Aggregation with ReduceFunction
> -------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-11004
> URL: https://issues.apache.org/jira/browse/FLINK-11004
> Project: Flink
> Issue Type: Bug
> Components: Documentation
> Affects Versions: 1.4.2, 1.5.5, 1.6.2
> Reporter: Yuanyang Wu
> Priority: Major
> Labels: pull-request-available
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> [https://ci.apache.org/projects/flink/flink-docs-release-1.6/dev/stream/operators/windows.html#incremental-window-aggregation-with-reducefunction]
> Example use wrong "window" argument in process()
> {{JAVA example}}
> {{- out.collect(new Tuple2<Long,
> SensorReading>({color:#d04437}window{color}.getStart(), min));}}
> {{+ out.collect(new Tuple2<Long,
> SensorReading>({color:#14892c}context.window(){color}.getStart(), min));}}
>
> {{Scala example 2nd argument should be context:Context instead of window}}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
