[
https://issues.apache.org/jira/browse/FLINK-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704599#comment-16704599
]
ASF GitHub Bot commented on FLINK-6756:
---------------------------------------
dawidwys commented on a change in pull request #7168: [FLINK-6756][DataStream
API] Provide Rich AsyncFunction to Scala API …
URL: https://github.com/apache/flink/pull/7168#discussion_r237783551
##########
File path:
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/AsyncDataStream.scala
##########
@@ -301,4 +287,21 @@ object AsyncDataStream {
orderedWait(input, timeout, timeUnit,
DEFAULT_QUEUE_CAPACITY)(asyncFunction)
}
+
+ private def wrapAsJavaAsyncFunction[IN, OUT: TypeInformation](
+ asyncFunction: AsyncFunction[IN, OUT])
+ : JavaAsyncFunction[IN, OUT] = asyncFunction match {
Review comment:
Add indentation. In scala the guidelines are to format code as follows:
```
private def wrapAsJavaAsyncFunction[IN, OUT: TypeInformation](
asyncFunction: AsyncFunction[IN, OUT])
: JavaAsyncFunction[IN, OUT] = asyncFunction match {
case richAsyncFunction: RichAsyncFunction[IN, OUT] =>
```
so that the colon has the same indentation as the code inside function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Provide RichAsyncFunction to Scala API suite
> --------------------------------------------
>
> Key: FLINK-6756
> URL: https://issues.apache.org/jira/browse/FLINK-6756
> Project: Flink
> Issue Type: Improvement
> Components: DataStream API
> Reporter: Andrea Spina
> Assignee: Andrea Spina
> Priority: Major
> Labels: pull-request-available
>
> I can't find any tracking info about the chance to have RichAsyncFunction in
> the Scala API suite. I think it'd be nice to have this function in order to
> access open/close methods and the RuntimeContext.
> I was able to retrieve
> http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/There-is-no-Open-and-Close-method-in-Async-I-O-API-of-Scala-td11591.html#a11593
> only, so my question is if there are some blocking issues avoiding this
> feature. [~till.rohrmann]
> If it's possible and nobody already have done it, I can assign the issue to
> myself in order to implement it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
