[ 
https://issues.apache.org/jira/browse/FLINK-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705621#comment-16705621
 ] 

ASF GitHub Bot commented on FLINK-6756:
---------------------------------------

Clarkkkkk commented on a change in pull request #7168: [FLINK-6756][DataStream 
API] Provide Rich AsyncFunction to Scala API …
URL: https://github.com/apache/flink/pull/7168#discussion_r238051554
 
 

 ##########
 File path: 
flink-streaming-scala/src/test/scala/org/apache/flink/streaming/api/scala/AsyncDataStreamITCase.scala
 ##########
 @@ -135,3 +158,19 @@ class MyAsyncFunction extends AsyncFunction[Int, Int] {
     resultFuture.complete(Seq(input * 3))
   }
 }
+
+class MyRichAsyncFunction extends RichAsyncFunction[Int, String] {
+  override def asyncInvoke(input: Int, resultFuture: ResultFuture[String]): 
Unit = {
 
 Review comment:
   I was also thinking about that. But here I want to verify the runtime I got 
here is a RichAsyncFunctionRuntimeContext, which is a private inner class of 
RichAsyncFunction. So I cannot use isInstanceOf to verify it. Perhaps I could 
move the inner class out of RichAsyncFunction and made it accessible by test, 
so I can verify the RuntimeContext.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Provide RichAsyncFunction to Scala API suite
> --------------------------------------------
>
>                 Key: FLINK-6756
>                 URL: https://issues.apache.org/jira/browse/FLINK-6756
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>            Reporter: Andrea Spina
>            Assignee: Andrea Spina
>            Priority: Major
>              Labels: pull-request-available
>
> I can't find any tracking info about the chance to have RichAsyncFunction in 
> the Scala API suite. I think it'd be nice to have this function in order to 
> access open/close methods and the RuntimeContext.
> I was able to retrieve 
> http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/There-is-no-Open-and-Close-method-in-Async-I-O-API-of-Scala-td11591.html#a11593
>  only, so my question is if there are some blocking issues avoiding this 
> feature. [~till.rohrmann]
> If it's possible and nobody already have done it, I can assign the issue to 
> myself in order to implement it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to