tweise commented on a change in pull request #6968: [FLINK-4582] [kinesis]
Consuming data from DynamoDB streams to flink
URL: https://github.com/apache/flink/pull/6968#discussion_r238817945
##########
File path:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ConsumerConfigConstants.java
##########
@@ -143,6 +143,34 @@ public SentinelSequenceNumber toSentinelSequenceNumber() {
/** The interval after which to consider a shard idle for purposes of
watermark generation. */
public static final String SHARD_IDLE_INTERVAL_MILLIS =
"flink.shard.idle.interval";
+ /**
+ * The base backoff time between each describeStream attempt.
+ * Different tag name to distinguish from
"flink.stream.describe.backoff.base"
+ * since the latter is deprecated.
+ */
+ public static final String DYNAMODB_STREAMS_DESCRIBE_BACKOFF_BASE =
Review comment:
It would be good to modify the method to map/replicate the keys but not
remove them (since you need them for dynamo). Add a comment that this is for
backward compatibility for the regular proxy that is now using listShards
instead of describeShards. We can remove the mapping in later release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
