QiLuo-BD commented on a change in pull request #7186: [FLINK-10941] Keep slots
which contain unconsumed result partitions
URL: https://github.com/apache/flink/pull/7186#discussion_r239314973
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
##########
@@ -902,6 +902,15 @@ private void checkTaskManagerTimeouts() {
// first retrieve the timed out TaskManagers
for (TaskManagerRegistration taskManagerRegistration :
taskManagerRegistrations.values()) {
if (currentTime -
taskManagerRegistration.getIdleSince() >= taskManagerTimeout.toMilliseconds()) {
+ // checking whether TaskManagers can be
safely removed
Review comment:
Yes, your proposal will improve resource utilization. But considering that
TM may be reused after all partitions are consumed (and before TM timeout), we
may discuss this optimization in another issue. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
