[
https://issues.apache.org/jira/browse/FLINK-11080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16712714#comment-16712714
]
ASF GitHub Bot commented on FLINK-11080:
----------------------------------------
zentol commented on a change in pull request #7247: [FLINK-11080][ES] Rework
shade-plugin filters
URL: https://github.com/apache/flink/pull/7247#discussion_r239778640
##########
File path: flink-connectors/flink-connector-elasticsearch6/pom.xml
##########
@@ -197,29 +197,57 @@ under the License.
<configuration>
<shadedArtifactAttached>true</shadedArtifactAttached>
<shadedClassifierName>sql-jar</shadedClassifierName>
+
<artifactSet>
+
<includes>
+
<include>*:*</include>
+
</includes>
+
<excludes>
+
<!-- These dependencies are not required. -->
+
<exclude>com.carrotsearch:hppc</exclude>
+
<exclude>com.tdunning:t-digest</exclude>
+
<exclude>joda-time:joda-time</exclude>
+
<exclude>net.sf.jopt-simple:jopt-simple</exclude>
+
<exclude>org.elasticsearch:jna</exclude>
+
<exclude>org.hdrhistogram:HdrHistogram</exclude>
+
<exclude>org.yaml:snakeyaml</exclude>
+
</excludes>
+
</artifactSet>
<filters>
<filter>
-
<artifact>*:*</artifact>
-
<!-- It is difficult to find out artifacts that are really required by
ES. -->
-
<!-- We use hard filters for now to clean up the SQL JAR. -->
+
<artifact>org.elasticsearch:elasticsearch</artifact>
<excludes>
-
<exclude>com/carrotsearch/**</exclude>
-
<exclude>com/sun/**</exclude>
Review comment:
org.elasticsearch:jna
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Define flink-connector-elasticsearch6 uber-jar dependencies via artifactSet
> ---------------------------------------------------------------------------
>
> Key: FLINK-11080
> URL: https://issues.apache.org/jira/browse/FLINK-11080
> Project: Flink
> Issue Type: Improvement
> Components: ElasticSearch Connector, SQL Client
> Affects Versions: 1.5.5, 1.6.2, 1.7.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.5.6, 1.6.3, 1.8.0, 1.7.1
>
>
> Similar to FLINK-11005.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
