[ 
https://issues.apache.org/jira/browse/FLINK-10943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713069#comment-16713069
 ] 

ASF GitHub Bot commented on FLINK-10943:
----------------------------------------

tillrohrmann commented on issue #7148: [FLINK-10943][tests] Fix test failures 
in flink runtime caused by curator dependency conflicts
URL: https://github.com/apache/flink/pull/7148#issuecomment-445289736
 
 
   Thanks for opening this PR @link3280. I'm wondering what the exact problem 
is which we are facing here. To me it looks as if the `flink-shaded-hadoop2` 
and `flink-shaded-curator` module correctly relocate the curator dependency. 
Therefore, there should be no problem with differing Curator versions.
   
   I would suspect that this problem arises if you run the test out of IntelliJ 
because it does not correctly respect relocated resources: 
https://youtrack.jetbrains.com/issue/IDEA-93855. Moreover, if you use a Maven 
version higher than `3.2.5`, then you need to run your build twice in order to 
generate the relocated artifacts.
   
   I was able to run `ZooKeeperStateHandleStoreTest` with Hadoop version 2.6.5 
and Maven version 3.2.5 by calling `mvn verify -pl flink-runtime`. Could you 
check whether this works for you as well?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Flink runtime test failed caused by curator dependency conflicts
> ----------------------------------------------------------------
>
>                 Key: FLINK-10943
>                 URL: https://issues.apache.org/jira/browse/FLINK-10943
>             Project: Flink
>          Issue Type: Bug
>          Components: Build System, Tests
>    Affects Versions: 1.5.5, 1.6.2
>            Reporter: Paul Lin
>            Assignee: Paul Lin
>            Priority: Minor
>              Labels: pull-request-available
>         Attachments: 
> org.apache.flink.runtime.zookeeper.ZooKeeperStateHandleStoreTest.txt
>
>
> Hadoop-common of 2.6 + version includes curator dependencies, which would 
> have conflicts with the curator used by Flink runtime and cause test failures 
> (the attachment is the surefire report). 
> The curator dependencies tree of flink runtime is as below:
> ```
> flink-shaded-hadoop2 -> hadoop-common -> curator-client & curator-recipes
> flink-shaded-curator -> curator-recipes -> curator-framework -> curator-client
> ```
> According to the dependency mechanism, maven would pick the curator-client in 
> flink-shaded-hadoop2, and curator-framework and curator-recipes from 
> flink-shaded-curator.
> To fix the problem I think we can simply exclude curator-client from 
> flink-shaded-hadoop2 dependency in flink-runtime.
> I'd like to fix this, please let me know what you think. Thanks!
> [^org.apache.flink.runtime.zookeeper.ZooKeeperStateHandleStoreTest.txt]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to