[ 
https://issues.apache.org/jira/browse/FLINK-10943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716150#comment-16716150
 ] 

ASF GitHub Bot commented on FLINK-10943:
----------------------------------------

link3280 closed pull request #7148: [FLINK-10943][tests] Fix test failures in 
flink runtime caused by curator dependency conflicts
URL: https://github.com/apache/flink/pull/7148
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/flink-runtime/pom.xml b/flink-runtime/pom.xml
index d216851c2d1..0cab4feabda 100644
--- a/flink-runtime/pom.xml
+++ b/flink-runtime/pom.xml
@@ -72,6 +72,12 @@ under the License.
                        <artifactId>flink-shaded-hadoop2</artifactId>
                        <version>${project.version}</version>
                        <optional>true</optional>
+                       <exclusions>
+                               <exclusion>
+                                       <groupId>org.apache.curator</groupId>
+                                       <artifactId>curator-client</artifactId>
+                               </exclusion>
+                       </exclusions>
                </dependency>
 
                <dependency>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Flink runtime test failed caused by curator dependency conflicts
> ----------------------------------------------------------------
>
>                 Key: FLINK-10943
>                 URL: https://issues.apache.org/jira/browse/FLINK-10943
>             Project: Flink
>          Issue Type: Bug
>          Components: Build System, Tests
>    Affects Versions: 1.5.5, 1.6.2
>            Reporter: Paul Lin
>            Assignee: Paul Lin
>            Priority: Minor
>              Labels: pull-request-available
>         Attachments: 
> org.apache.flink.runtime.zookeeper.ZooKeeperStateHandleStoreTest.txt
>
>
> Hadoop-common of 2.6 + version includes curator dependencies, which would 
> have conflicts with the curator used by Flink runtime and cause test failures 
> (the attachment is the surefire report). 
> The curator dependencies tree of flink runtime is as below:
> ```
> flink-shaded-hadoop2 -> hadoop-common -> curator-client & curator-recipes
> flink-shaded-curator -> curator-recipes -> curator-framework -> curator-client
> ```
> According to the dependency mechanism, maven would pick the curator-client in 
> flink-shaded-hadoop2, and curator-framework and curator-recipes from 
> flink-shaded-curator.
> To fix the problem I think we can simply exclude curator-client from 
> flink-shaded-hadoop2 dependency in flink-runtime.
> I'd like to fix this, please let me know what you think. Thanks!
> [^org.apache.flink.runtime.zookeeper.ZooKeeperStateHandleStoreTest.txt]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to