StefanRRichter commented on a change in pull request #6684: [FLINK-10205]
Batch Job: InputSplit Fault tolerant for DataSource…
URL: https://github.com/apache/flink/pull/6684#discussion_r240247384
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex.java
##########
@@ -590,6 +604,15 @@ public Execution resetForNewExecution(final long
timestamp, final long originati
this.currentExecution = newExecution;
+ synchronized (this.inputSplits){
+ for (InputSplit split:
this.inputSplits){
+ if (split != null) {
+
this.jobVertex.getSplitAssigner().returnInputSplit(split,
this.getParallelSubtaskIndex());
+ }
+ }
+ this.inputSplits.clear();
Review comment:
I think in general the code-style in Flink avoids prefixing members with
`this.` outside of constructors, getters, and setters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
