StefanRRichter commented on a change in pull request #6684: [FLINK-10205]
Batch Job: InputSplit Fault tolerant for DataSource…
URL: https://github.com/apache/flink/pull/6684#discussion_r240246077
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex.java
##########
@@ -250,6 +255,15 @@ public CoLocationConstraint getLocationConstraint() {
return locationConstraint;
}
+ public InputSplit getNextInputSplit(String host) {
+ final int taskId = this.getParallelSubtaskIndex();
+ synchronized (this.inputSplits) {
+ final InputSplit nextInputSplit =
this.jobVertex.getSplitAssigner().getNextInputSplit(host, taskId);
+ this.inputSplits.add(nextInputSplit);
Review comment:
I would suggest to check for `null` here and only call add for non-null
splits.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
