pnowojski commented on a change in pull request #6871:
[FLINK-10583][FLINK-10584][table] Add State Retention to temporal joins.
URL: https://github.com/apache/flink/pull/6871#discussion_r240992848
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TemporalRowtimeJoin.scala
##########
@@ -205,6 +203,7 @@ class TemporalRowtimeJoin(
val rightRowsSorted = getRightRowsSorted(rightRowtimeComparator)
var lastUnprocessedTime = Long.MaxValue
+ // TODO: here we should check if the right side has anything or not
(optimization).
Review comment:
You can create a separate hotfix for that if you want. It's a valid and
simply improvement, but probably not super critical.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
