pnowojski commented on a change in pull request #6871:
[FLINK-10583][FLINK-10584][table] Add State Retention to temporal joins.
URL: https://github.com/apache/flink/pull/6871#discussion_r240992121
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/util/TwoInputStreamOperatorTestHarness.java
##########
@@ -64,4 +64,9 @@ public void processWatermark1(Watermark mark) throws
Exception {
public void processWatermark2(Watermark mark) throws Exception {
twoInputOperator.processWatermark2(mark);
}
+
+ public void advanceWatermark(Watermark mark) throws Exception {
Review comment:
`advanceWatermark` is inconsistent with `processWatermark1` and
`processWatermark2`. Why haven't you called it `processWatermarks` or
`processBothWatermarks`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
