sunjincheng121 commented on a change in pull request #7209: 
[FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API
URL: https://github.com/apache/flink/pull/7209#discussion_r244908219
 
 

 ##########
 File path: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
 ##########
 @@ -1028,6 +1060,128 @@ class Table(
   }
 }
 
+class FlatAggTable(
+  private[flink] val table: Table,
+  private[flink] val tableAggCall: TableAggFunctionCall) {
+
+  /**
+    * Performs a selection operation on a FlatAggTable table. Similar to an 
SQL SELECT statement.
+    * The field expressions can contain complex expressions.
+    *
+    * __Note__: You have to close the flatAggregate with a select statement. 
And the select
+    * statement does not support aggregate functions.
+    *
+    * Example:
+    *
+    * {{{
+    *   val tableAggFunc: TableAggregateFunction = new MyTableAggregateFunction
 
 Review comment:
   Remove `TableAggregateFunction` , IDE will report the compiler error if we 
do not add the type info. 
   and for a simple way I also agree remove this line , and only using the 
follows code:
   ```
   tab.flatAggregate(tableAggregateFunc('a, 'b)).select(udf('_1), '_2, '_3)
   ```
   Which user  know that not the complete example.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to