sunjincheng121 commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r244906630
########## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala ########## @@ -1028,6 +1061,119 @@ class Table( } } +class FlatAggTable( Review comment: +1 for remove the `FlatAggTable` in this change. Because there are no difference at current time. And rename `GroupedFlatAggTable` to `FlatAggregateTable`. Frankly speaking, I don't want to introduce more types. For example, `aggregate` and `flatAggregate` are based on GroupedTable, but because of user-friendlyness restrictions, limit the description of errors, such as `groupedTable.flatAggreage().flatAggreage()` So we have to introduce a new type. For the sake of conciseness and completeness of class names, I tend to name the new type that can only perform select operations as `FlatAggregateTable` . BTW, for `aggregate` We call `AggregateTable` in FLINK-10976. What to you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
