StefanRRichter commented on a change in pull request #7009: [FLINK-10712]
Support to restore state when using RestartPipelinedRegionStrategy
URL: https://github.com/apache/flink/pull/7009#discussion_r245651506
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/FailoverRegion.java
##########
@@ -206,13 +206,21 @@ private void restart(long globalModVersionOfFailover) {
try {
if (transitionState(JobStatus.CREATED,
JobStatus.RUNNING)) {
// if we have checkpointed state, reload it
into the executions
- //TODO: checkpoint support restore part
ExecutionVertex cp
- /**
if (executionGraph.getCheckpointCoordinator()
!= null) {
+ // we restart the checkpoint scheduler
for
+ // i) enable new checkpoint could be
triggered without waiting for last checkpoint expired.
+ // ii) ensure the EXACTLY_ONCE
semantics if needed.
+ if
(executionGraph.getCheckpointCoordinator().isPeriodicCheckpointingConfigured())
{
Review comment:
I suggest to reference the `CheckpointCoordinator` object with a `final`
local variable, instead of calling the getter all the time, this makes the code
more readable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
