StefanRRichter commented on a change in pull request #7009: [FLINK-10712]
Support to restore state when using RestartPipelinedRegionStrategy
URL: https://github.com/apache/flink/pull/7009#discussion_r245660458
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java
##########
@@ -180,25 +184,24 @@ private void assignAttemptState(ExecutionJobVertex
executionJobVertex, List<Oper
*/
assignTaskStateToExecutionJobVertices(
executionJobVertex,
+ subTaskIndices,
newManagedOperatorStates,
newRawOperatorStates,
newManagedKeyedState,
- newRawKeyedState,
- newParallelism);
+ newRawKeyedState);
}
private void assignTaskStateToExecutionJobVertices(
- ExecutionJobVertex executionJobVertex,
- Map<OperatorInstanceID, List<OperatorStateHandle>>
subManagedOperatorState,
- Map<OperatorInstanceID, List<OperatorStateHandle>>
subRawOperatorState,
- Map<OperatorInstanceID, List<KeyedStateHandle>>
subManagedKeyedState,
- Map<OperatorInstanceID, List<KeyedStateHandle>>
subRawKeyedState,
- int newParallelism) {
+ ExecutionJobVertex executionJobVertex,
Review comment:
There are a lot of unrelated formatting changes for method parameters. Can
you please revert all the indentation changes because the make the diff bigger
and therefore reviews harder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
