EugeneYushin commented on a change in pull request #6760: [FLINK-10422] Follow
AWS specs in Kinesis Consumer
URL: https://github.com/apache/flink/pull/6760#discussion_r245738168
##########
File path:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
##########
@@ -454,18 +453,6 @@ private ListShardsResult listShards(String streamName,
@Nullable String startSha
}
}
}
- // Kinesalite (mock implementation of Kinesis) does not
correctly exclude shards before
Review comment:
Kinesalite has nothing in relation to prod code. And test code shouldn't
affect prod code.
Looks like all Flink tests have passed successfully with proposed changes,
haven't they?
BTW, Kinesalite doesn't look like an active anymore. Last commit has been
made `mhart committed on Jun 20, 2018`.
There're pull requests from 2016 ongoing. I've proposed a change to fix the
issue in Sep, 2018 but with no feedback:
https://github.com/mhart/kinesalite/pull/77
So, event if it's used, somebody should consider to shift to more reliable
implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
