EugeneYushin commented on a change in pull request #6760: [FLINK-10422] Follow
AWS specs in Kinesis Consumer
URL: https://github.com/apache/flink/pull/6760#discussion_r245743712
##########
File path:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
##########
@@ -454,18 +453,6 @@ private ListShardsResult listShards(String streamName,
@Nullable String startSha
}
}
}
- // Kinesalite (mock implementation of Kinesis) does not
correctly exclude shards before
Review comment:
Unfortunately, I don't.
But keeping Kinesalite requires writing the code which doesn't conform to
AWS specs. That's the point.
I think it's better to create your own implementation for mocking kinesis
(if there're no reliable ones on the market) rather then keeping workaround
implementation which is not supported by AWS officially.
AWS could change inner implementation (e.g. switch from `^shardId-\\d{12}`
to something else, this is not a part of public contract) which would break all
users' scripts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
