zentol commented on a change in pull request #7409: [FLINK-11064] [table] Setup a new flink-table module structure URL: https://github.com/apache/flink/pull/7409#discussion_r246331954
########## File path: flink-table/flink-table-runtime/src/main/resources/META-INF/NOTICE ########## @@ -0,0 +1,10 @@ +flink-table-runtime +Copyright 2014-2018 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +This project bundles the following dependencies under the BSD license. +See bundled license files for details + +- org.codehaus.janino:janino:3.0.7 Review comment: this is incorrect as flink-table-runtime isn't bundling any dependencies (as in, it is not included in the jar). Which raises the question: which module is now bundling janino? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
