tillrohrmann commented on a change in pull request #6876: [FLINK-10251] Handle
oversized response messages in AkkaRpcActor
URL: https://github.com/apache/flink/pull/6876#discussion_r246333472
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcActor.java
##########
@@ -85,13 +87,21 @@
private final int version;
+ private final long maximumFramesize;
+
private State state;
- AkkaRpcActor(final T rpcEndpoint, final CompletableFuture<Boolean>
terminationFuture, final int version) {
+ public AkkaRpcActor(
+ final T rpcEndpoint,
+ final CompletableFuture<Boolean> terminationFuture,
+ final int version,
+ final long maximumFramesize) {
+
this.rpcEndpoint = checkNotNull(rpcEndpoint, "rpc endpoint");
this.mainThreadValidator = new
MainThreadValidatorUtil(rpcEndpoint);
this.terminationFuture = checkNotNull(terminationFuture);
this.version = version;
+ this.maximumFramesize = maximumFramesize;
Review comment:
should check that this is positive
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
