tillrohrmann commented on a change in pull request #6876: [FLINK-10251] Handle
oversized response messages in AkkaRpcActor
URL: https://github.com/apache/flink/pull/6876#discussion_r246342188
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaInvocationHandler.java
##########
@@ -123,6 +125,21 @@ public Object invoke(Object proxy, Method method,
Object[] args) throws Throwabl
"retrieve a properly FencedRpcGateway.");
} else {
result = invokeRpc(method, args);
+ if (result instanceof CompletableFuture) {
+ result = ((CompletableFuture)
result).thenApply((Object o) -> {
+ if (o instanceof SerializedValue) {
+ try {
+ return
((SerializedValue) o).deserializeValue(getClass().getClassLoader());
+ } catch (IOException e) {
+ throw new
CompletionException(e);
+ } catch (ClassNotFoundException
e) {
+ throw new
CompletionException(e);
+ }
+ } else {
+ return o;
+ }
+ });
+ }
Review comment:
We should also add a test case that synchronous calls (Rpc's which return
directly a value instead of a `CompletableFuture`) work with this change as
well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
