tillrohrmann commented on a change in pull request #6876: [FLINK-10251] Handle 
oversized response messages in AkkaRpcActor
URL: https://github.com/apache/flink/pull/6876#discussion_r246341255
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
 ##########
 @@ -757,7 +758,7 @@ protected RpcService createRpcService(
 
                final ActorSystem actorSystem = 
AkkaUtils.createActorSystem(effectiveAkkaConfig);
 
-               return new AkkaRpcService(actorSystem, askTimeout);
+               return new AkkaRpcService(actorSystem, 
AkkaRpcServiceConfiguration.fromConfiguration(configuration));
 
 Review comment:
   I would suggest to replace the `askTimeout` parameter with a 
`AkkaRpcServiceConfiguration akkaRpcServiceConfiguration` parameter and pass it 
to this method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to