pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r246322448
########## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/logical/LogicalToEnumerableTableScan.scala ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.plan.rules.logical + +import org.apache.calcite.adapter.enumerable.EnumerableTableScan +import org.apache.calcite.plan.RelOptRule.{any, operand} +import org.apache.calcite.plan.{RelOptRule, RelOptRuleCall, RelOptRuleOperand} +import org.apache.calcite.rel.logical.LogicalTableScan + +/** + * Rule that converts a LogicalTableScan into an EnumerableTableScan. We need this rule to Review comment: If calling a rule only once is impossible, I would be in favour of implementing a separate step similar to `RelTimeIndicatorConverter`. Current approach is a bit hacky: 1. converting back and forth `EnumerableTableScan` & `LogicalTableScan` is not clean on it's own 2. it interconnects with already existing `EnumerableToLogicalTableScan` which is a kind of hack on it's own. 3. `EnumerableToLogicalTableScan` previously had a different purpose and it's better to have two smaller independent components (old `EnumerableToLogicalTableScan` & new `UpsertToRetractionConverter` (?)) that have nothing to do with another, then squeezing them together. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
