pnowojski commented on a change in pull request #6787: [FLINK-8577][table]
Implement proctime DataStream to Table upsert conversion
URL: https://github.com/apache/flink/pull/6787#discussion_r247954694
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/UpdatingPlanChecker.scala
##########
@@ -183,6 +183,17 @@ object UpdatingPlanChecker {
lJoinKeys.zip(rJoinKeys)
)
}
+
+ case l: DataStreamUpsertToRetraction =>
+ val uniqueKeyNames = l.getRowType.getFieldNames.zipWithIndex
+ .filter(e => l.keyIndexes.contains(e._2))
+ .map(_._1)
+ Some(uniqueKeyNames.map(e => (e, e)))
+
+ case scan: UpsertStreamScan =>
Review comment:
This big `match` `case` looks veerryy strange... Why isn't it solved in some
more object oriented way like via a visitor pattern?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
